Visual studio feeds

All Visual Studio blogs in one place


Enter your email address:

Delivered by FeedBurner

Increase your website traffic with



Anti-spam: How many eyes has a typical person?

Follow us on FB


Your ctor says that your code is headache inducing: Explanation

AddThis Social Bookmark Button
I was pointed to this codebase, as a good candidate for review. As usual, I have no contact with the project owners, and I am merely using the code as a good way to discuss architecture and patterns. It starts with this class: Okay, this codebase is going to have the following problems: Complex and complicated Hard to maintain Hard to test Probably contains a lot of code “best practices” that are going to cause a lot of pain And I said that this is the case without looking at any part of
the code except for this constructor. How am I so certain of that? Put simply, with 9 dependencies, and especially with those kind of dependencies, I can pretty much ensure that this class already violate the Single Responsibility Principle. It is just doing too much, too complex and too fragile. I shudder to think what is involved in testing something like that. Now, to be fair, I looked at the rest of the codebase, and it seems like I caught it in a state of flux, with a lot of stuff still not implemented. Nevertheless… this is a recipe for...(Read whole news on source site)

Home : Blog List : Ayende @ Rahien : Your ctor says that your code is headache inducing: Explanation